Skip to content

XS✔ ◾ feat(service): set appProtocol to http2 on http ports#7

Merged
dimoschi merged 2 commits into
mainfrom
typesense/http2
Apr 28, 2026
Merged

XS✔ ◾ feat(service): set appProtocol to http2 on http ports#7
dimoschi merged 2 commits into
mainfrom
typesense/http2

Conversation

@dimoschi
Copy link
Copy Markdown
Collaborator

@dimoschi dimoschi commented Apr 28, 2026

Summary

  • Adds appProtocol: http2 to the HTTP port definition on both the regular Service and the headless Service
  • Updates tests/service_test.yaml to assert the new field in port assertions

Test plan

  • mise run test passes (91/91 tests green)
  • mise run lint passes

@dimoschi dimoschi requested a review from a team as a code owner April 28, 2026 12:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 4
Test Code 3
Subtotal 7
Ignored Code 2
Total 9

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions Bot changed the title feat(service): set appProtocol to http2 on http ports XS✔ ◾ feat(service): set appProtocol to http2 on http ports Apr 28, 2026
Copy link
Copy Markdown

@cpapad cpapad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Solve protocol mismatch in interpod communication

@dimoschi dimoschi merged commit 36ba9f0 into main Apr 28, 2026
3 checks passed
@dimoschi dimoschi deleted the typesense/http2 branch April 28, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants