Modified current-projects.js to remove OR logic from project filter

[aadilahmed]

Fixes #8353

What changes did you make?

• Modified code on line 537 in updateProjectCardDisplayState method to ensure AND logic within same filter category
• Added conditional to updateProjectCardDisplayState method to ensure AND logic between different filter categories

Why did you make the changes (we will use this info to test)?

• To ensure that AND logic is applied to all filter categories selected on the project page
• Make sure the filter is easier to use and navigate

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

• I have checked this PR for CodeQL alerts and none were found.
• I found CodeQL alert(s), and (select one):
  • I have resolved the CodeQL alert(s) as noted
  • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
  • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b aadilahmed-update-project-filter-remove-or-logic-8353 gh-pages
git pull https://github.com/aadilahmed/website.git update-project-filter-remove-or-logic-8353

[dvernon5]

Hello @aadilahmed, thank you for taking on this project.

What you did well:

• You successfully replaced the conditional statement on line 537
• You successfully wrapped the conditional statement on line 586
• In the filter toolbar, when you select the same category, the AND logic is applied successfully
• When you search categories in the search bar, the OR logic is properly applied
• After each operation, the project page updates with the correct selected project while staying functional

Issues Found: None, I found no issues with this implementation.

Congratulations on a fantastic job. I'll go ahead and approve this!

[viet456]

Review ETA: 4/20 10PM

[viet456]

Hi @aadilahmed , you made all the necessary changes in this PR.
I did leave a comment about .map() vs .forEach() but it's a small detail of no issue.
Thanks for your contributions. Approved

[viet456]

Nit: Since the issue instructions used .map() here, this isn't on you, but consider .forEach() instead.

cardsToHideContainer.forEach(item => document.getElementById(`${item[1]}`).style.display = 'none');

.map() is reserved for transformations that use the returned array. Here it's purely a side effect, which is what .forEach() is for.

It's non blocking, and you did follow the instructions well. Thanks for the contribution