Skip to content

Update Table: User | Model | API | Test cases - #616

Merged
fyliu merged 1 commit into
hackforla:mainfrom
Ruchitha12:feature/update_user
Jun 18, 2026
Merged

Update Table: User | Model | API | Test cases#616
fyliu merged 1 commit into
hackforla:mainfrom
Ruchitha12:feature/update_user

Conversation

@Ruchitha12

@Ruchitha12 Ruchitha12 commented Feb 5, 2026

Copy link
Copy Markdown
Member

Fixes #601

What changes did you make?

Why did you make the changes (we will use this info to test)?

  • To align the User model with the updated intake schema requirements.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No UI, only backend changes

@fyliu

fyliu commented Feb 12, 2026

Copy link
Copy Markdown
Member

I rebased to main and updated the migration file numbering, making sure tests and linters are passing. I haven't looked at the code yet.

@fyliu fyliu moved this to 👀PR being reviewed in P: PD: Project Board Feb 12, 2026

@fyliu fyliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I think we need some clarification on the requirements for this to be sure. I will bring it up at the meeting.

Comment thread app/core/models.py Outdated
@github-project-automation github-project-automation Bot moved this from 👀PR being reviewed to PR changes requested in P: PD: Project Board Feb 12, 2026
@fyliu
fyliu force-pushed the feature/update_user branch 2 times, most recently from e3c7118 to d55d2e9 Compare June 16, 2026 22:29
@fyliu fyliu moved this from PR changes requested to PR Needs review (automated column, do not place items here manually) in P: PD: Project Board Jun 16, 2026
@fyliu fyliu self-assigned this Jun 16, 2026
@fyliu
fyliu force-pushed the feature/update_user branch from d55d2e9 to 58c7626 Compare June 16, 2026 23:13
@fyliu

fyliu commented Jun 16, 2026

Copy link
Copy Markdown
Member
  • made changes according to current requirements
  • merged migrations
  • rebased to main

@egcuriel
egcuriel self-requested a review June 17, 2026 05:34

@egcuriel egcuriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, the changes reflect the updated requirements. Should these changes be incorporated into PRs waiting to be merged/Issues currently open, or should this PR include any changes those PRs have incorporated/Issues currently open?

@fyliu

fyliu commented Jun 18, 2026

Copy link
Copy Markdown
Member

@egcuriel I think it's fine if PRs end up conflicting with one another. If the PR was worked on for a long time, it should be rebased to the latest main code or something recent, just to make sure the changes don't break any recent code.

@fyliu fyliu moved this from PR Needs review (automated column, do not place items here manually) to 🔖PR ready to merge in P: PD: Project Board Jun 18, 2026
@fyliu
fyliu merged commit fb54f6c into hackforla:main Jun 18, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from 🔖PR ready to merge to ✅Done in P: PD: Project Board Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Update Table: User

3 participants