feat(shop): add 'Made by a teen' banner to shop items#763
Open
sreyasaju wants to merge 2 commits into
Open
Conversation
- Adds teen_creator_url to ShopItems via migration - Updates ShopItemCardComponent to render the banner - Includes styling and tests Closes hackclub#692
Collaborator
Member
|
Not a massive fan of this - the item cards are already somewhat cluttered, I don't think we should be adding more to them without adjusting how they currently are Maybe we could have a little hack clubber icon to represent this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #692
what's this do?
This PR adds a "Made by a teen!" ribbon to shop items that have a teen_creator_url defined, to help spotlight items created by hackclubbers directly on the card.
show it works
BEFORE
AFTER along with other ribbons
AFTER
testing
HCA was not used, testing was done locally by creating a test user and applying a teen_creator_url to a ShopItem.
Initializing a test user
and applying a testing url and banner to existing shop item card (which was the Outpost ticket)
ai?
Copilot assisted with the local testing process and formatting the data setup commands!