-
Notifications
You must be signed in to change notification settings - Fork 80
feat(lookout): nudge never-tracked users to Lookout on the /rng page #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhamariT
wants to merge
4
commits into
feat/lookout-default-flow
Choose a base branch
from
feat/lookout-rng-nudge
base: feat/lookout-default-flow
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
09abf17
feat(lookout): nudge never-tracked users to Lookout on the /rng page
dhamariT 8df065b
refactor(lookout): use the guest-banner style for the /rng nudge
dhamariT 6096a28
feat(lookout): render the /rng banner as a top sticky bar
dhamariT 00157c7
copy(lookout): frame the /rng banner as the easy way to log hours
dhamariT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <%# Top sticky re-engagement banner. Reuses the .guest-banner styling — the | ||
| yellow bar shown when you don't have a Hack Club account (see | ||
| components/_onboarding.scss) — so it sits at the top of the screen exactly | ||
| like that banner. Rendered from the application layout when the controller | ||
| set @lookout_banner_origin (currently only on /rng, for signed-in viewers | ||
| who are behind :lookout and haven't linked Hackatime yet). | ||
| Locals: origin (required — where /auth/hackatime returns them). %> | ||
| <div class="guest-banner" id="lookout-banner" role="status"> | ||
| <p class="guest-banner__copy"> | ||
| the easy way to log your build time — just hit record in your browser with Lookout. no install, no editor extension. | ||
| </p> | ||
| <%= button_to "Log hours with Lookout", "/auth/hackatime", | ||
| method: :post, | ||
| params: { origin: origin }, | ||
| class: "guest-banner__cta", | ||
| form: { class: "guest-banner__form" }, | ||
| data: { turbo: false } %> | ||
| </div> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong project recency ordering
Medium Severity
lookout_nudge_originpicks the Hackatime return destination withprojects.order(created_at: :desc), but elsewhere the app treats the user’s active project asprojects.order(updated_at: :desc)(home composer and project show). After linking, users with multiple projects can land on a stale or empty project instead of the one they actually use.Reviewed by Cursor Bugbot for commit 09abf17. Configure here.