fix: disable link to devlog on devlog page#682
Open
ultravioletasdf wants to merge 1 commit into
Open
Conversation
Adds "clickable" parameter, when set to false will disable the click action. Defaults to true, so will not effect other areas of code
EnterpriseGoose
requested changes
Jun 25, 2026
EnterpriseGoose
left a comment
EnterpriseGoose
left a comment
Collaborator
There was a problem hiding this comment.
just one edit to make this a bit cleaner
| actions = [ data[:action], "click->card-link#navigate auxclick->card-link#navigate" ].compact.join(" ") | ||
| end | ||
|
|
||
| data.merge( |
Collaborator
There was a problem hiding this comment.
instead of just commenting out the actions, can you make it not have any clickable data if the card is not clickable so it makes a fully clean, static card?
Contributor
Author
|
Seems to be fixed? Sorry I wasn't able to do this myself, I've been busy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's this do?
On a devlog page, the devlog was originally clickable, which meant it would link to itself.
I added a
clickableparameter which disables the link, it defaults to true so will not affect other areas of code.show it works
stardance_disable_devlog_clickable.mp4
ai?
nope