Skip to content

Publish canonical lens database release asset#29

Open
partyplatter08-lab wants to merge 1 commit into
gyroflow:mainfrom
partyplatter08-lab:partyplatter08-lab/publish-canonical-lenses
Open

Publish canonical lens database release asset#29
partyplatter08-lab wants to merge 1 commit into
gyroflow:mainfrom
partyplatter08-lab:partyplatter08-lab/publish-canonical-lenses

Conversation

@partyplatter08-lab

Copy link
Copy Markdown

Scope

This companion PR supports gyroflow/gyroflow#742 by publishing the canonical camera/lens database as a release asset next to profiles.cbor.gz.

What changed

  • Added canonical_lenses.json at the repository root.
    • Current generated contents: version 37, 258 brands, 52 mounts, 2,638 cameras, 7,111 lenses, and 6,517 observed setup rows.
    • Sources recorded in the file:
      • gyroflow/lens_profiles commit bf0976d039d27a64b54517adfa941443865a492e
      • lensfun/lensfun commit 01e64b74507d9b818478f0e02f338fada8dd5680
  • Updated compress.rs so canonical_lenses.json is not packed into profiles.cbor.gz as a legacy lens profile.
  • Updated .github/workflows/release.yml so releases include both:
    • profiles.cbor.gz
    • canonical_lenses.json

Why

The app-side gyroflow/gyroflow change downloads canonical_lenses.json through the existing lens profile update path. Keeping this file as a separate release asset avoids changing the existing profile bundle format while giving the app a canonical identity/index database for later selector and compatibility work.

Validation

  • git -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol diff --check
    • Passes in gyroflow/lens_profiles.
  • The same canonical_lenses.json is present in both repos:
    • gyroflow/resources/camera_presets/canonical_lenses.json
    • lens_profiles/canonical_lenses.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant