fix: download zlib from zlib.net/fossils (root URL now 404s)#1
Merged
Conversation
zlib.net only serves the current release at the root path; older versions are moved to the permanent /fossils/ archive. zlib 1.3.2 is now current, so https://zlib.net/zlib-1.3.1.tar.gz returns 404, which made wget write no file and the subsequent `tar xzf zlib-1.3.1.tar.gz` fail, breaking the gocr WASI build. Point the pinned 1.3.1 download at /fossils/, which is a permanent archive and won't move again when future zlib versions are released. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The WASI build (
install_libpng_wasi.sh) downloads zlib fromhttps://zlib.net/zlib-1.3.1.tar.gz, which now returns 404.zlib.netonly serves the current release at the root path; older versions are moved to the permanent/fossils/archive. zlib 1.3.2 is now current, so the pinned 1.3.1 tarball is no longer at the root.wgetgot the 404 and (by default) wrote no file, so the next step'star xzf zlib-1.3.1.tar.gzfailed — breaking the gocr build.Change
Keeps the pinned
1.3.1version (no dependency change) and points at/fossils/, a permanent archive that won't move again when future zlib versions are released.Verification
https://zlib.net/zlib-1.3.1.tar.gz→ 404https://zlib.net/fossils/zlib-1.3.1.tar.gz→ 200 (1,512,791 bytes)Built end-to-end as part of the SLEdge
make install(viagwsystems/sledge-serverless-framework): the gocr.wasm.socompiles and the runtime OCR's the test image to the exactexpected_result.txt.Context / upstream chain
This is the only content change needed; once merged, the submodule pointer needs bumping up the chain:
gwsystems/wasm_apps→gwsystems/aWsm→gwsystems/sledge-serverless-framework. Companion top-level fixes: gwsystems/sledge-serverless-framework#388.🤖 Generated with Claude Code