Skip to content

docs(#524): fix pre-script and permissions in custom agents guide#541

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/524-fix-custom-agents-guide
Open

docs(#524): fix pre-script and permissions in custom agents guide#541
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/524-fix-custom-agents-guide

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Remove Jira-specific code from the pre-script example since Jira support was removed upstream (PR fullsend-ai#2568). Convert the orphaned elif to a direct gh CLI call. Add issues: write to the workflow permissions block (was missing). Remove the now-unused issue_source workflow input and ISSUE_SOURCE env var.


Closes #524

Post-script verification

  • Branch is not main/master (agent/524-fix-custom-agents-guide)
  • Secret scan passed (gitleaks — b776cf6006a12016eaa21412dc65a3001100e801..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Remove Jira-specific code from the pre-script example since
Jira support was removed upstream (PR fullsend-ai#2568). Convert the
orphaned elif to a direct gh CLI call. Add issues: write to
the workflow permissions block (was missing). Remove the
now-unused issue_source workflow input and ISSUE_SOURCE env
var.

Closes #524
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 5:38 PM UTC · Completed 5:45 PM UTC
Commit: b776cf6 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Verdict: request-changes

The PR correctly fixes the two bugs described in #524 — the broken elif without preceding if in the pre-script example (replaced with a direct gh issue view call), and the missing issues: write permission. However, the removal of the issue_source workflow input introduces three stale references within the same file that the diff does not update, creating new documentation inconsistencies.

Findings

# Severity Category Location Description
1 medium stale-reference building-custom-agents.md:471 Step 8 instructions tell users to "fill in issue_key and issue_source" but the workflow example no longer defines an issue_source input.
2 medium stale-reference building-custom-agents.md:472 CLI example gh workflow run my-agent.yml -f issue_key=123 -f issue_source=github passes a parameter that no longer exists in the workflow definition.
3 medium stale-reference building-custom-agents.md:506 Slash-command dispatch example passes -f issue_source="github" to a workflow that no longer accepts this input.

Suggested fixes

Line 471 — remove the and \issue_source`` reference:

- **From the GitHub UI:** Actions → fullsend-my-agent → Run workflow → fill in `issue_key`.

Line 472 — remove -f issue_source=github:

- **From the CLI:** `gh workflow run my-agent.yml -f issue_key=123`... 506** — remove the `-f issue_source="github"` line from the dispatch example.

### What's correct

- Pre-script fix: removing the entire Jira/GitHub conditional and keeping only the `gh issue view` call is the right approach — simpler and correct.
- Adding `issues: write` to the single permissions block is correct.
- Removing the `issue_source` input and `ISSUE_SOURCE` env var from the workflow is appropriate cleanup.
- No security concerns. No secrets in the diff. The `issues: write` addition is in an example code block, not a production workflow.

### Note on scope

The `.fullsend/customized/` directory in this repo contains Jira-related infrastructure (e.g., `jira-parser` skill, `stp-builder` agent) that is separate from this guide. The guide shows a generic example for building custom agents and does not need to mirror this repo's specific Jira integration. The Jira removal from the guide is consistent with the upstream change (PR #2568) cited in issue #524.

---
**Labels:** PR fixes documentation bugs in a user guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix elif syntax error and duplicate permissions block in building-custom-agents guide

0 participants