docs(#524): fix pre-script and permissions in custom agents guide#541
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#524): fix pre-script and permissions in custom agents guide#541fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Remove Jira-specific code from the pre-script example since Jira support was removed upstream (PR fullsend-ai#2568). Convert the orphaned elif to a direct gh CLI call. Add issues: write to the workflow permissions block (was missing). Remove the now-unused issue_source workflow input and ISSUE_SOURCE env var. Closes #524
|
🤖 Finished Review · ❌ Failure · Started 5:38 PM UTC · Completed 5:45 PM UTC |
ReviewVerdict: request-changes The PR correctly fixes the two bugs described in #524 — the broken Findings
Suggested fixesLine 471 — remove the Line 472 — remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Jira-specific code from the pre-script example since Jira support was removed upstream (PR fullsend-ai#2568). Convert the orphaned elif to a direct gh CLI call. Add issues: write to the workflow permissions block (was missing). Remove the now-unused issue_source workflow input and ISSUE_SOURCE env var.
Closes #524
Post-script verification
agent/524-fix-custom-agents-guide)b776cf6006a12016eaa21412dc65a3001100e801..HEAD)