fix(#197): add fallback path for companion scripts in post-fix.sh#508
fix(#197): add fallback path for companion scripts in post-fix.sh#508fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
When post-fix.sh runs from the content-addressed cache (sha256/<hash>/content), process-fix-result.py is not co-located. Add a fallback that checks FULLSEND_DIR/scripts/ when the companion is not found at the BASH_SOURCE-relative path. This is the same class of bug as the skill companion resolution issue (fullsend-ai#2705), applied to post-scripts. The pre-commit tool companions in post-code.sh were already replaced with inline installs, so only post-fix.sh needed the fallback. Add post-fix-test.sh to verify the fallback resolution logic and register it in the Makefile script-test target. Closes #197
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
|
🤖 Finished Review · ✅ Success · Started 3:30 PM UTC · Completed 3:39 PM UTC |
Review — PR #508Verdict: approve SummaryThis PR adds a fallback path resolution for The change is small (6 lines of production code), correctly scoped to the stated issue, and follows the approach recommended in #197 (Option A). A 95-line test file validates the resolution logic, and the Makefile Security: The fallback runs AFTER all security gates (protected-path check, secret scan, pre-commit). Observations
Labels: Bug fix for post-script companion resolution in dispatch pipeline |
When post-fix.sh runs from the content-addressed cache (sha256//content), process-fix-result.py is not co-located. Add a fallback that checks FULLSEND_DIR/scripts/ when the companion is not found at the BASH_SOURCE-relative path.
This is the same class of bug as the skill companion resolution issue (fullsend-ai#2705), applied to post-scripts. The pre-commit tool companions in post-code.sh were already replaced with inline installs, so only post-fix.sh needed the fallback.
Add post-fix-test.sh to verify the fallback resolution logic and register it in the Makefile script-test target.
Closes #197
Post-script verification
agent/197-fix-companion-fallback)b776cf6006a12016eaa21412dc65a3001100e801..HEAD)