Skip to content

docs(#200): document mint deploy-time source stamping pattern#506

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/200-mint-stamping-docs
Open

docs(#200): document mint deploy-time source stamping pattern#506
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/200-mint-stamping-docs

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Add prescriptive guidance to the Mint function section of AGENTS.md explaining that build metadata for the mint Cloud Function should use deploy-time source stamping rather than runtime environment variables. This prevents metadata from drifting out of sync with the deployed function code.

The paragraph uses aspirational language describing the intended pattern, since the mechanism is not yet fully implemented in the codebase. It guides future agents to choose source stamping over env vars when adding build metadata to the Cloud Function.


Closes #200

Post-script verification

  • Branch is not main/master (agent/200-mint-stamping-docs)
  • Secret scan passed (gitleaks — b776cf6006a12016eaa21412dc65a3001100e801..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add prescriptive guidance to the Mint function section of AGENTS.md
explaining that build metadata for the mint Cloud Function should
use deploy-time source stamping rather than runtime environment
variables. This prevents metadata from drifting out of sync with
the deployed function code.

The paragraph uses aspirational language describing the intended
pattern, since the mechanism is not yet fully implemented in the
codebase. It guides future agents to choose source stamping over
env vars when adding build metadata to the Cloud Function.

Closes #200
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:25 PM UTC · Completed 3:32 PM UTC
Commit: b776cf6 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review — approve

PR: docs(#200): document mint deploy-time source stamping pattern
Scope: 1 file changed (AGENTS.md), +2 lines

Clean documentation addition. The paragraph accurately describes the deploy-time source stamping pattern for the mint Cloud Function and is well-placed in the "Mint function" section of AGENTS.md between the mintcore sync guidance and the dispatch workflows section.

Dimensions reviewed

Dimension Result
Correctness ✅ Technical claims are accurate — env vars can drift from deployed code (confirmed by UpdateServiceEnvVars in provisioner.go which updates env vars without redeploying). Aspirational language is appropriate since the stamping mechanism is prescriptive guidance.
Security ✅ No secrets, injection patterns, or permission changes.
Intent & coherence ✅ Traces directly to issue #200. Scope matches exactly — single paragraph of prescriptive guidance as authorized. No scope creep.
Style & conventions ✅ Follows the existing **Bold header:** pattern used by sibling paragraphs in the Go code section.
Docs currency ⏭ Skipped — this is a docs-only PR; no code changes to evaluate staleness against.
Cross-repo contracts ⏭ Skipped — no exported APIs modified.

Minor observation (non-blocking)

The example path mintcore/version.go places generated version metadata inside the shared mintcore module rather than at the function source root. Since mintcore is shared with devmint and has .embed sync requirements, a top-level version.go might be a more natural location for mint-specific build metadata. However, the paragraph uses "e.g." to mark this as an example rather than a prescription, and the path matches the upstream implementation referenced in issue #200.


Verdict: Approve. This is a well-scoped, correctly-placed documentation addition that fills a documented guidance gap (issue #200) to prevent future agents from choosing env vars over source stamping for Cloud Function build metadata.


Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

  • AGENTS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ARCHIVED] Original issue 200

0 participants