Skip to content

docs(#341): document agent content migration to fullsend-ai/agents#500

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/341-document-agent-content-migration
Open

docs(#341): document agent content migration to fullsend-ai/agents#500
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/341-document-agent-content-migration

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Add AGENTS.md section noting that agent definitions, skills, and harness configs have moved to fullsend-ai/agents. Add deprecation README.md in each stale scaffold directory (agents/, skills/, harness/) to prevent contributors from modifying the wrong copies.


Closes #341

Post-script verification

  • Branch is not main/master (agent/341-document-agent-content-migration)
  • Secret scan passed (gitleaks — b776cf6006a12016eaa21412dc65a3001100e801..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add AGENTS.md section noting that agent definitions, skills, and harness
configs have moved to fullsend-ai/agents. Add deprecation README.md in
each stale scaffold directory (agents/, skills/, harness/) to prevent
contributors from modifying the wrong copies.
@github-actions

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:11 PM UTC · Completed 3:18 PM UTC
Commit: b776cf6 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review — PR #500

Verdict: Approve

Clean, well-scoped documentation change that implements exactly what issue #341 requested: an AGENTS.md section documenting the agent content migration to fullsend-ai/agents, plus deprecation READMEs in the three stale scaffold directories.

Checks performed

Dimension Result
Correctness ✅ All three scaffold directories (agents/, skills/, harness/) exist at the stated paths. Deprecation READMEs are placed correctly. Paths in AGENTS.md are accurate.
Security ✅ No secrets, no injection patterns, no Unicode steganography, no permission changes. PR body is clean.
Intent & coherence ✅ Change precisely matches issue #341's proposed fix — no scope creep. Section placement in AGENTS.md is logical (after existing scaffold sync rules, before Go development guidance).
Style & conventions ✅ Heading level, link format, path formatting, and imperative tone all match existing AGENTS.md conventions.
Docs currency ⚠ See follow-up note below.
Cross-repo contracts ⏭ Skipped — no exported interfaces modified.

Follow-up: stale references to deprecated paths

Multiple documentation files still reference the deprecated scaffold paths as authoritative sources. This is pre-existing staleness (not introduced by this PR), but the new AGENTS.md guidance creates a mild contradiction with these references:

  • docs/agents/README.md and all agent doc files (code.md, fix.md, prioritize.md, retro.md, review.md, triage.md) link to scaffold harness YAMLs as canonical sources
  • docs/guides/user/customizing-agents.md references raw GitHub URLs pointing to the scaffold harness
  • docs/guides/user/running-agents-locally.md contains examples using the deprecated scaffold paths

Additionally, the Go scaffold package (internal/scaffold/scaffold.go) still embeds and serves content from these directories at runtime via //go:embed, so the files remain operationally necessary until the code is migrated. The AGENTS.md wording ("will be removed" — future tense) is accurate but contributors should be aware the files cannot be deleted yet.

These are separate follow-up items, not blockers for this PR.


Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

  • AGENTS.md

Labels: PR adds documentation about agent content migration — the documentation label applies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ARCHIVED] Benchmark issue 341

0 participants