Install golangci-lint and fix lint issues#3
Merged
riccardo-perotti merged 3 commits intoJun 8, 2026
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jsimmons-flowspace
approved these changes
Jun 8, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs golangci-lint in CI and fixes all reported issues (7). Lint clean (0 issues); build/vet/test pass. dbr-go has no gudtech module deps.
CI
Added a
lintjob to.github/workflows/build.yml(golangci/golangci-lint-action@v6, Go 1.26) — the live pipeline. The.circleci/config.ymlis a dead stub and was left untouched. No.golangci.yml— default linters.Fixes by file
common.go
io/ioutil→os.ReadFile×2 (SA1019 + govet inline); dropped theio/ioutilimport.RestrictedReadAccounts:fmt.Errorf(no args) →errors.New, plus a//nolint:staticcheckfor ST1012 (see note).account.go — QF1004:
strings.Replace(…, -1)→strings.ReplaceAll(exact equivalent).All fixes behavior-preserving; no DB error handling / control flow altered.
Note — ST1012 suppressed, not renamed
staticcheck wants the exported
RestrictedReadAccountsvar renamed to theErr…convention. That's an exported identifier in a foundational module consumed by many services viago get, so renaming is a breaking API change. Suppressed with//nolint:staticcheckrather than renamed; a coordinated rename across consumers would be a separate ticket.Jira Tickets
https://gudtech.atlassian.net/browse/ROP-9229
🤖 Generated with Claude Code