enable preventing pipe injection#373
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attackers with the same uid (or root) can inject the pipe parallel uses to trigger code execution
The /proc//fd/ pipe reopen is just one technique among many. Closing it with HMAC while leaving ptrace wide open is like adding a deadbolt to one of ten unlocked doors. Virtually every Ruby gem
that uses Marshal over a pipe (DRb, many job systems, forking web servers' status sockets, etc.) has the same property, and none of them HMAC.
So I'm adding an option to use a safe serializer since I wanted to support different serializers anyways, but it's not really a necessary default.
Credit to: Anas Cherni from Calif.io in collaboration with Claude and Anthropic Research.