Skip to content

Fix Launch4j version metadata format breaking Windows packaging in build-and-release - #35

Closed
MateZsebehazi with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-build-and-release-job
Closed

Fix Launch4j version metadata format breaking Windows packaging in build-and-release#35
MateZsebehazi with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-build-and-release-job

Conversation

Copilot AI commented Aug 4, 2026

Copy link
Copy Markdown

The build-and-release workflow failed in the Windows packaging step because Launch4j generated an invalid RC FILEVERSION from the date-based project version (2026.08.04.1). windres rejects zero-padded numeric segments like 08/04 in that context.

  • Root cause

    • CimPal-Main Launch4j config mapped ${cimpal.version} directly into numeric version fields:
      • <fileVersion>
      • <productVersion>
    • This produced invalid RC numeric literals for windres.
  • Change made

    • Updated Launch4j numeric version fields in CimPal-Main/pom.xml to use a windres-safe numeric format (no zero-padded date segments) for:
      • fileVersion
      • productVersion
    • Kept string version fields unchanged for display/metadata continuity:
      • txtFileVersion
      • txtProductVersion
  • Why this is safe

    • Change is isolated to Windows executable metadata generation in Launch4j.
    • No runtime application logic or dependency behavior is altered.
<versionInfo>
  <fileVersion>2026,8,4,1</fileVersion>          <!-- numeric, windres-safe -->
  <txtFileVersion>${cimpal.version}</txtFileVersion>
  <productVersion>2026,8,4,1</productVersion>    <!-- numeric, windres-safe -->
  <txtProductVersion>${cimpal.version}</txtProductVersion>
</versionInfo>

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'build-and-release' Fix Launch4j version metadata format breaking Windows packaging in build-and-release Aug 4, 2026
Copilot AI requested a review from MateZsebehazi August 4, 2026 08:20
@MateZsebehazi
MateZsebehazi deleted the copilot/fix-build-and-release-job branch August 4, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants