Skip to content

Fix Return Desk provider value identities - #38

Merged
softmarshmallow merged 1 commit into
mainfrom
feature/return-desk-provider-identities
Jul 24, 2026
Merged

Fix Return Desk provider value identities#38
softmarshmallow merged 1 commit into
mainfrom
feature/return-desk-provider-identities

Conversation

@softmarshmallow

Copy link
Copy Markdown
Member

Summary

  • align the A0 Return Desk provider with the exact checked module and port value identities
  • accept the canonical request RequestPort case and emit the declared Settlement::Accepted case
  • add a focused browser-local provider regression test
  • include the example provider/test in the permanent provider lint and Vitest gates

Root cause

The hand-authored provider encoded source-facing spellings (app.return_desk.machine, returns.request, and lowercase accepted) instead of the checked runtime identities produced by the Uhura 0.4 contract. The browser-local host therefore rejected otherwise valid commands or settlements at the provider boundary.

Impact

The Return Desk answer provider can now exchange values with its checked machine without identity/case mismatches. This changes only the example provider and its validation coverage.

Checks

  • corepack pnpm@10.11.0 -C web check
    • typecheck passed
    • provider and web lint passed
    • app/export/provider builds passed
    • 47 test files passed; 335 tests passed, 2 skipped
  • focused Return Desk provider test passed
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@softmarshmallow, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f6985fc0-1103-4c32-9b1b-b85ba74b47a0

📥 Commits

Reviewing files that changed from the base of the PR and between 1625da0 and c04ef97.

📒 Files selected for processing (4)
  • examples/applications/a0-return-desk/answers/uhura-0.4/provider.mjs
  • examples/applications/a0-return-desk/answers/uhura-0.4/provider.test.mjs
  • web/package.json
  • web/vitest.config.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/return-desk-provider-identities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@softmarshmallow
softmarshmallow marked this pull request as ready for review July 24, 2026 05:52
@softmarshmallow
softmarshmallow merged commit 4cf7938 into main Jul 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant