docs: surface FI in nodejs-v2 sub-README and npm description#5
Merged
Merged
Conversation
The main README and SUPPORTED_ENTITIES already reflect FI_HETU and FI_BUSINESS_ID (added in gregmos#4 / v2.2.0), but two surfaces still listed "EU/UK/US patterns" and "33 entity types": - `nodejs-v2/README.md` — the sub-README rendered on the package path - `nodejs-v2/package.json` description — what shows up on the npm registry page Update both lists in place (same wording style): bump 33 → 35 and extend `EU/UK/US` → `EU/UK/US/FI`. No semver/runtime impact.
gregmos#5 updated the nodejs-v2 README blurb and the npm description, but three "Detected entity types" surfaces were left stale at 33 / 29 pattern-based and omitted FI entirely: - nodejs-v2/README.md "What it detects" — 33->35, +31 pattern, +FI in country list - nodejs-v2/cli/USAGE.md — 33->35 types, +FI_HETU/FI_BUSINESS_ID - README.md (root) — 33->35 (4 NER + 31 pattern), +FI_HETU/FI_BUSINESS_ID Counts verified against SUPPORTED_ENTITIES in nodejs-v2/src/engine/entity-types.ts (35 = 4 NER + 31 pattern). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Small docs follow-up to #4 / v2.2.0. The main README and
SUPPORTED_ENTITIESalready reflectFI_HETUandFI_BUSINESS_ID, but two public-facing surfaces still listedEU/UK/US patternsand33 entity types:nodejs-v2/README.md— the sub-README rendered on the package pathnodejs-v2/package.jsondescription — what shows up on the npm registry pageChange
Same wording style, lists updated in place:
33 → 35entity typesEU/UK/US → EU/UK/US/FIpatternsNo semver/runtime impact — purely metadata.