Skip to content

fix #757: Add new azure extensions reference for SqlClient 7#759

Merged
hoangthanh28 merged 2 commits into
grate-devs:mainfrom
wokket:feat/#757-sqlclient-deps
Jun 15, 2026
Merged

fix #757: Add new azure extensions reference for SqlClient 7#759
hoangthanh28 merged 2 commits into
grate-devs:mainfrom
wokket:feat/#757-sqlclient-deps

Conversation

@wokket

@wokket wokket commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@wokket wokket requested a review from hoangthanh28 June 13, 2026 21:56
@wokket wokket added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 13, 2026
@hoangthanh28

Copy link
Copy Markdown
Collaborator

Hi @wokket
Can you add it to the main grate.csproj console project instead of the grate.sqlserver.csproj‎? This package needs to be copied with the output artifact.

Thanks.

@wokket

wokket commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

I've added the ref to the grate project as well, although by this logic we'd need the oracle/postgres/mysql/etc libs all referenced from grate to get them in the package, which clearly isn't the case....

@hoangthanh28

Copy link
Copy Markdown
Collaborator

@wokket
Hi mate.
If you don't add in the host project (in this case grate.csproj), the dependency will become intransitive and won't copy with the output.
I ran the diff between the output of your 2 commits - see below:

image

Other cases of postgres, mysql, oracle... these dependencies are transitive because the host project uses them.

@wokket wokket linked an issue Jun 14, 2026 that may be closed by this pull request
@hoangthanh28 hoangthanh28 merged commit 0fefcb1 into grate-devs:main Jun 15, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.Data.SqlClient 7.x breaking change

2 participants