Skip to content

redis cache set ttl in seconds #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramiel wants to merge 3 commits into
base: main
Choose a base branch
from
Open

redis cache set ttl in seconds #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a4afb2
Set redis cache in seconds
ramiel Apr 2, 2025
c1b1596
Remove badly formatted code
ramiel May 14, 2025
0e5aa95
Updated tests
ramiel May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugins/response-cache-redis/src/redis-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const createRedisCache = (params: RedisCacheParameter): Cache => {
pipeline.set(responseId, JSON.stringify(result));
} else {
// set the ttl in milliseconds
pipeline.set(responseId, JSON.stringify(result), 'PX', ttl);
pipeline.set(responseId, JSON.stringify(result), 'EX', ttl);
}

const responseKey = buildRedisOperationResultCacheKey(responseId);
Expand Down
12 changes: 6 additions & 6 deletions packages/plugins/response-cache-redis/test/response-redis-cache.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,8 +797,8 @@ describeIf(versionInfo.major >= 16)('useResponseCache with Redis cache', () => {
// so queried just once
expect(spy).toHaveBeenCalledTimes(1);

// let's travel in time beyond the ttl of 100
jest.advanceTimersByTime(150);
// let's travel in time beyond the ttl of 100 seconds
jest.advanceTimersByTime(150_000);

// since the cache has expired, now when we query
await testInstance.execute(query);
Expand Down Expand Up @@ -1083,8 +1083,8 @@ describeIf(versionInfo.major >= 16)('useResponseCache with Redis cache', () => {
await testInstance.execute(query);
expect(spy).toHaveBeenCalledTimes(1);

// wait so User expires
jest.advanceTimersByTime(201);
// wait so User expires, beyond 200 seconds
jest.advanceTimersByTime(201_000);

await testInstance.execute(query);
// now we've queried twice
Expand Down Expand Up @@ -1174,8 +1174,8 @@ describeIf(versionInfo.major >= 16)('useResponseCache with Redis cache', () => {
await testInstance.execute(query);
expect(spy).toHaveBeenCalledTimes(1);

// wait so User expires
jest.advanceTimersByTime(201);
// wait so User expires beyond 200 seconds
jest.advanceTimersByTime(201_000);

await testInstance.execute(query);
// now we've queried twice
Expand Down