Skip to content

chore: fix reqresp suite - #121

Open
SoarinSkySagar wants to merge 1 commit into
grandinetech:devnet-5from
SoarinSkySagar:reqresp
Open

chore: fix reqresp suite#121
SoarinSkySagar wants to merge 1 commit into
grandinetech:devnet-5from
SoarinSkySagar:reqresp

Conversation

@SoarinSkySagar

Copy link
Copy Markdown

grandine currently returns empty response on zero blocks or too many blocks requests. This PR fixes that by adding an error status code instead.

@SoarinSkySagar SoarinSkySagar changed the title fix reqresp suite chore: fix reqresp suite Aug 4, 2026
@SoarinSkySagar

Copy link
Copy Markdown
Author

I actually made the same change as part of #114, but for some reason it got overwritten to the previous code somehow, so submitting this change again.

@SoarinSkySagar

Copy link
Copy Markdown
Author

got it, it came from here. @bomanaps the suites expect an error code when zero blocks or too many blocks are sent, sending empty responses results in test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant