add proposal budget opts, single-flight, leanSpec fixes - #111
Conversation
ArtiomTr
left a comment
ArtiomTr
left a comment
There was a problem hiding this comment.
Looks fine, but please:
- Provide proper pull request name
- Provide proper pull request description
- Rebase commits into logical, atomic, updates. If you're doing 3 things, pr should contain 3 commits, and every commit should have proper name/description
Without that, it becomes extremely complicated to understand what happens in PR at all.
| all_validator_ids.dedup(); | ||
| let all_participants = AggregationBits::from_validator_indices(&all_validator_ids); | ||
| METRICS.get().map(|m| { | ||
| m.lean_aggregation_job_setup_seconds |
There was a problem hiding this comment.
why not timer used here?
There was a problem hiding this comment.
I added it so I can tell whether a slow aggregation session is the Rust-side setup work or the SNARK itself without polluting the spec metric
There was a problem hiding this comment.
Understood, but keep in mind that custom metrics should be prefixed with grandine_, not lean_.
But that doesn't change my point - you can still use proper prometheus timer, instead of custom float value, computed via Instant.
Am sorry about this |
|
No problem, this is just a recommendation - makes easier to maintain and review PRs. Can you also please don't use the opt-1/opt-2 naming, as it is a bit confusing, without reference to the article? I mean, you can just name them "early-bird proposal optimization"/"skipping proof compaction during proposal" |
7fd85b7 to
5ec22ee
Compare
bomanaps
changed the title
|
Looks like commits are still not cleaned up? I see 6 commits |
5ec22ee to
fca609f
Compare
2 participants
Implements block-proposal budget optimizations from leanSpec PRs #1177/#1178/#1179/#1181/#1182 early-bird proposal that slides the build window into the previous slot's interval-4 view-merge, and skipping proof compaction on the proposer so aggregators absorb it https://hackmd.io/@MegaRedHand/HJM6d_eQMx, also includes a ProduceBlock single-flight guard, aggregation retention-leak fix with corrected metric scope, proposer head-lag guard, XMSS advance_preparation to stop the slot-131,072 sign panic, and an attestation-signing metric scope fix.