fix(helm): skip OCI repos in helm_repo_update#9
Open
NickAnge wants to merge 1 commit into
Open
Conversation
OCI registries do not use the traditional index-based `helm repo update` flow. Passing them through causes `helm repo update` to fail with "invalid reference". Filter them out and return early if no non-OCI repos remain.
Benchmark Results
Full results available in workflow artifacts. Benchmark run on commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm_repo_updatepasses all repos tohelm repo update, including OCI registries (oci://). OCI registries don't use the index-based update flow — they're pulled directly by URL — sohelm repo updatefails withinvalid referencewhen it encounters one.This filters out OCI repos before calling
helm repo updateand returns early if no non-OCI repos remain.helm_pullalready handles OCI correctly viachart_pull_path, so this only affects the update step.Affects any chartfile using OCI repos (e.g. karpenter, cert-manager, envoy-gateway, kepler, tinkerbell in deployment_tools).
Test
test_repo_update_oci_only_skips_helm— passes only OCI repos tohelm_repo_update, assertsOk(())without needinghelmon PATHrtk tool charts vendoragainst the deployment_tools karpenter chartfile (two OCI chart versions)