Skip to content

fix(model): keep zero-score search results#1279

Open
he-yufeng wants to merge 1 commit into
gorse-io:masterfrom
he-yufeng:fix/model-search-zero-score
Open

fix(model): keep zero-score search results#1279
he-yufeng wants to merge 1 commit into
gorse-io:masterfrom
he-yufeng:fix/model-search-zero-score

Conversation

@he-yufeng

Copy link
Copy Markdown

Summary

  • keep the first completed CF/CTR model-search trial even when its score is zero
  • add regression coverage for zero-score CF and CTR searches

Why

With very small datasets, every optimization trial can legitimately score 0. The previous comparison only saved a result when the score was strictly greater than the zero-value score, leaving the selected model empty after optimization.

To verify

  • go test ./model/cf ./model/ctr
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant