Skip to content

Move sync namespace check to helper. #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ensonic merged 1 commit into from
May 19, 2026
Merged

Move sync namespace check to helper. #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/go/pkg/synk/synk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"log/slog"
"reflect"
"regexp"
"slices"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -410,6 +411,15 @@ func (s *Synk) applyAll(
return results, err
}

func validateNamespace(r *unstructured.Unstructured, optsNs string) error {
ns := r.GetNamespace()
allowed := []string{"", "kube-system", optsNs}
if slices.Contains(allowed, ns) {
return nil
}
return errors.Errorf("invalid namespace %q on %q, expected one of %v", ns, resourceKey(r), allowed)
}

// initialize a new ResourceSet version for the given name and prepare resources
// for it.
func (s *Synk) initialize(
Expand All @@ -432,8 +442,8 @@ func (s *Synk) initialize(
// so we can give validation errors in batch in the ResourceSet status.
if opts.EnforceNamespace {
for _, r := range regulars {
if ns := r.GetNamespace(); ns != "" && ns != opts.Namespace && ns != "kube-system" {
return nil, nil, errors.Errorf("invalid namespace %q on %q, expected %q or \"kube-system\"", ns, resourceKey(r), opts.Namespace)
if err := validateNamespace(r, opts.Namespace); err != nil {
return nil, nil, err
}
}
}
Expand Down
Loading