Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Add "swipeAnywhere" attribute - #45

Open
sethmiles wants to merge 1 commit into
googlearchive:masterfrom
sethmiles:patch-1
Open

Add "swipeAnywhere" attribute#45
sethmiles wants to merge 1 commit into
googlearchive:masterfrom
sethmiles:patch-1

Conversation

@sethmiles

Copy link
Copy Markdown

This allows a drawer to be opened by swiping in the middle of the screen instead of just the edges.

Mobile Safari sends the browser back or forward on swipes originating from the edge of the screen, making it difficult if not impossible to open a drawer.

This allows a drawer to be opened by swiping in the middle of the screen instead of just the edges.

Mobile Safari sends the browser back or forward on swipes originating from the edge of the screen, making it difficult if not impossible to open a drawer.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@sethmiles

Copy link
Copy Markdown
Author

I filled out the CLA for myself, thanks.

On Monday, January 12, 2015, googlebot notifications@github.com wrote:

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source
project, in which case you'll need to sign a Contributor License Agreement
(CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub
username or you're using a different email address. Check the information
on your CLA https://cla.developers.google.com/clas or see this help
article on setting the email on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Once you've done that, please reply here to let us know. If you signed the
CLA as a corporation, please let us know the company's name.


Reply to this email directly or view it on GitHub
#45 (comment)
.

Seth

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@addyosmani

Copy link
Copy Markdown
Contributor

This could be neat to support. Do you forsee any issues with landing swipe support for this use-case, @frankiefu?

@ssorallen

Copy link
Copy Markdown
Contributor

I like the idea, and I think it could be pulled out into a mixin (in 0.8 land) to allow other elements to understand similar gestures. iOS has a UIGestureRecognizer class for encapsulating the logic to know when a gesture has happened. The trackX, trackEnd, trackStart, etc. methods in core-drawer-panel could be moved to a mixin. That might be a better way forward than adding custom logic in multiple elements.

@ssorallen

Copy link
Copy Markdown
Contributor

polymer-gestures is close to adding swipe: googlearchive/polymer-gestures#50

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants