This repository was archived by the owner on Mar 13, 2018. It is now read-only.
disable text selection while dragging drawer on desktop - #29
Open
semateos wants to merge 2 commits into
Open
Conversation
|
Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide. |
Author
|
Ok, thanks! I just signed the CLA. |
Contributor
There was a problem hiding this comment.
Prefer declarative bindings rather than reaching into the DOM:
<div id="main" class="{{ {noselect: dragging} | tokenList }}" ...><div id="drawer" class="{{ {noselect: dragging} | tokenList }}" ...>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While generally not an issue because few people would attempt to drag the drawer on desktop, it is nice for quick testing. Also, there are some potential use cases where folks might take advantage of the drawer dragging feature in a desktop ui. Let me know if the add/remove class is not the best way to handle stuff like this.