feat: [Gax] Add script to download and generate the showcase client and download the showcase server#9347
Merged
Merged
Conversation
Hectorhammett
marked this pull request as ready for review
July 16, 2026 22:03
bshaffer
reviewed
Jul 17, 2026
Hectorhammett
force-pushed
the
generate-conformance-tests
branch
from
July 20, 2026 21:08
67b386e to
f5c0273
Compare
cy-yun
reviewed
Jul 20, 2026
bshaffer
reviewed
Jul 20, 2026
bshaffer
reviewed
Jul 20, 2026
cy-yun
requested changes
Jul 21, 2026
cy-yun
reviewed
Jul 21, 2026
cy-yun
approved these changes
Jul 22, 2026
bshaffer
reviewed
Jul 22, 2026
bshaffer
left a comment
bshaffer
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Most of what I have is nits - I think we have a lot of opportunities to simplify this.
bshaffer
reviewed
Jul 24, 2026
Contributor
There was a problem hiding this comment.
This is great! I tested it locally and it ran first time! Woohoo.
However when I ran it, all the message files were updated. I am running libprotoc 35.0, so maybe that's why? Can we do this with the most recent version of protoc so that we get all the latest versions of these files?
Also, the update to symfony/yaml seems to have broken our DocFX tests. We could update them, but I'd rather understand why it's necessary, as this is downgrading our installed version from v6 to v5
bshaffer
reviewed
Jul 24, 2026
Hectorhammett
force-pushed
the
generate-conformance-tests
branch
from
July 24, 2026 19:00
ce9a0ad to
6686e3b
Compare
bshaffer
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a script for downloading and generating the showcase client for the conformance tests. This client was generated a long time ago and we need a consistent way to generate and update the showcase client and server, specially with PQC around the corner.
Closes: #9229
Depends on: googleapis/gapic-generator-php#838
BEGIN_COMMIT_OVERRIDE
feat(dev): add showcase:generate command and update showcase client (#9347)
END_COMMIT_OVERRIDE