feat: API configuration: 20260810T090051Z - #15811
Conversation
|
Pull request diff results |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds configuration for the new Google.Cloud.Ftp.V1 API in both apis.json and pipeline-state.json. Feedback is provided regarding the transport configuration for this new API, suggesting a change from 'rest' to 'grpc' to align with its gRPC type.
| "includeCommonResourcesProto": true, | ||
| "shortName": "ftp", | ||
| "serviceConfigFile": "ftp_v1.yaml", | ||
| "transport": "rest", |
There was a problem hiding this comment.
The transport is configured as rest for a grpc type API. Typically, gRPC-based APIs should use grpc or grpc+rest as their transport to leverage the performance benefits of gRPC. Change this to grpc or grpc+rest unless the service explicitly only supports REST.
| "transport": "rest", | |
| "transport": "grpc", |
There was a problem hiding this comment.
Confirmed with API team this a rest only API for now, see b/543711406.
| "includeCommonResourcesProto": true, | ||
| "shortName": "ftp", | ||
| "serviceConfigFile": "ftp_v1.yaml", | ||
| "transport": "rest", |
There was a problem hiding this comment.
Confirmed with API team this a rest only API for now, see b/543711406.
2 participants
Changes in this PR