feat(Storage): Add x-goog-gcs-idempotency-token idempotency header - #15778
Open
mahendra-google wants to merge 1 commit into
Open
feat(Storage): Add x-goog-gcs-idempotency-token idempotency header#15778mahendra-google wants to merge 1 commit into
mahendra-google wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an automatic idempotency token header (x-goog-gcs-idempotency-token) for retriable Google Cloud Storage requests. It implements IdempotencyTokenInterceptor to inject a unique GUID as the token if the header is not already present, and registers this interceptor in RetryHandler. Additionally, a unit test has been added to verify that the idempotency header is correctly set and remains consistent across retried requests. There are no review comments, and I have no further feedback to provide.
amanda-tarafa
approved these changes
Aug 4, 2026
amanda-tarafa
left a comment
amanda-tarafa
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but please get someone from the Storage team to review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains only the first part of the feature request i.e. Add request idempotency header to each JSON API request and add a unit test for this. Please see b/280811916 for reference.
This PR implements automatic injection of the
x-goog-gcs-idempotency-tokenheader for retriable requests. This ensures that retries of the same request are recognized as identical by the server, preventing duplicate operations.