feat: add setup and test agentic skills - #321
Open
brianquinlan wants to merge 6 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and configuration for generating and releasing Google Cloud API packages in Dart. It introduces a detailed release guide (RELEASING.md), updates the main README.md, and adds setup and testing markdown files (SKILL.md) for multiple Google Cloud services, alongside updating API source commits in librarian.yaml. The review feedback is highly constructive, pointing out a missing step in the release guide regarding updating the Librarian version in librarian.yaml, as well as minor grammatical and phrasing inconsistencies in the newly added setup and test markdown files.
Contributor
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the new file
generated/RELEASING.md, which describes the first steps in the generated-code release process. I will add more steps to that process as I complete them.Restructures
generated/README.mdto avoid duplication withgenerated/RELEASING.md.Modifies some test file to avoid duplicate imports now that every
google_cloud_*library exportspackage:google_cloud_rpc/exceptions.dart.The remaining changes are done through automation by completing steps 1-4 from
generated/RELEASING.md.