Skip to content

fix: update protobuf monorepo#808

Open
renovate-bot wants to merge 1 commit into
googleapis:mainfrom
renovate-bot:renovate/protobuf-monorepo
Open

fix: update protobuf monorepo#808
renovate-bot wants to merge 1 commit into
googleapis:mainfrom
renovate-bot:renovate/protobuf-monorepo

Conversation

@renovate-bot
Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
Google.Protobuf 3.34.13.35.0 age confidence
com.google.protobuf:protobuf-bom (source) 4.34.14.35.0 age confidence

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • Between 12:00 AM and 03:59 AM (* 0-3 * * *)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner May 20, 2026 01:51
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Google Protobuf version to 3.35.0 for the .NET wrapper and 4.35.0 for the Java wrapper. Feedback was provided regarding the Maven dependency management in the Java project, specifically suggesting that the protobuf-bom import be moved earlier in the dependencyManagement section to ensure the version update takes precedence over other imported BOMs.

<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-bom</artifactId>
<version>4.34.1</version>
<version>4.35.0</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The protobuf-bom is currently imported after google-cloud-spanner-bom in the dependencyManagement section. In Maven, the first declaration of a managed dependency takes precedence. Since google-cloud-spanner-bom likely manages the version of protobuf-java and other protobuf artifacts, the update to 4.35.0 here may be ignored in favor of the version specified in the spanner BOM. To ensure the new version is applied and remains compatible with other libraries, the protobuf-bom import should be moved before the google-cloud-spanner-bom import.

References
  1. When updating dependencies, especially those not managed by a BOM, verify the version's release date to ensure it is current and compatible with other libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant