fix: update protobuf monorepo#808
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Google Protobuf version to 3.35.0 for the .NET wrapper and 4.35.0 for the Java wrapper. Feedback was provided regarding the Maven dependency management in the Java project, specifically suggesting that the protobuf-bom import be moved earlier in the dependencyManagement section to ensure the version update takes precedence over other imported BOMs.
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-bom</artifactId> | ||
| <version>4.34.1</version> | ||
| <version>4.35.0</version> |
There was a problem hiding this comment.
The protobuf-bom is currently imported after google-cloud-spanner-bom in the dependencyManagement section. In Maven, the first declaration of a managed dependency takes precedence. Since google-cloud-spanner-bom likely manages the version of protobuf-java and other protobuf artifacts, the update to 4.35.0 here may be ignored in favor of the version specified in the spanner BOM. To ensure the new version is applied and remains compatible with other libraries, the protobuf-bom import should be moved before the google-cloud-spanner-bom import.
References
- When updating dependencies, especially those not managed by a BOM, verify the version's release date to ensure it is current and compatible with other libraries.
This PR contains the following updates:
3.34.1→3.35.04.34.1→4.35.0Configuration
📅 Schedule: (UTC)
* 0-3 * * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.