fix: pass forward debugger properties on exception - #989
Merged
robertvoinescu-work merged 1 commit intoJul 30, 2026
Conversation
…ges on exception.
There was a problem hiding this comment.
Code Review
This pull request refactors the initialization of CodeGeneratorResponse in Google.Api.Generator/Program.cs by extracting the supported features, minimum edition, and maximum edition values into private constants. These constants are now consistently applied to both the successful and failure response generation paths. There are no review comments, and the changes are clean and correct, so I have no feedback to provide.
efevans
approved these changes
Jul 30, 2026
amanda-tarafa
approved these changes
Jul 30, 2026
Contributor
|
Merge this one as is, but @efevans can you take a look at the zizmor check failures and fix them on a separate PR? |
Contributor
Will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On exception we will get misleading error messages from protoc compiler if these are not passed forward. Note the specified properties are
[DebuggerNonUserCode]:Before (has misleading message to add support for optional fields):
After:
b/540852437