Skip to content

Fix subclass discovery to support multi-level parser hierarchies #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awe-srush wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Fix subclass discovery to support multi-level parser hierarchies #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion vanir/language_parsers/language_parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,19 @@
_P = TypeVar('_P', bound=abstract_language_parser.AbstractLanguageParser)


def _all_subclasses(cls):
"""Recursively collect all concrete (non-abstract) subclasses of cls."""
result = []
for sub in cls.__subclasses__():
if not sub.__abstractmethods__:
result.append(sub)
result.extend(_all_subclasses(sub))
return result


def get_parser_class(filename: str) -> Optional[Type[_P]]:
"""Returns the language parser class that handles the given file, or None."""
parsers = abstract_language_parser.AbstractLanguageParser.__subclasses__()
parsers = _all_subclasses(abstract_language_parser.AbstractLanguageParser)
ext = os.path.splitext(filename)[1]
for parser_class in parsers:
if ext in parser_class.get_supported_extensions():
Expand Down