fix(discovery-engine): grant Discovery Engine service agent objectViewer on corpus bucket - #219
Open
AloysJehwin wants to merge 1 commit into
Open
Conversation
…wer on corpus bucket Without roles/storage.objectViewer on the GCS corpus buckets, the Discovery Engine service agent cannot read documents during import, causing every `gem4gov datastore import` to fail with PERMISSION_DENIED and zero documents indexed. Fixes google#145 Signed-off-by: Aloys Jehwin <aloysjehwin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #145
The
discovery-engine.tfcreates GCS corpus buckets for Discovery Engine data stores but never grants the Discovery Engine service agent (service-<project_number>@gcp-sa-discoveryengine.iam.gserviceaccount.com)roles/storage.objectVieweron them. This causes everygem4gov datastore importto silently fail withPERMISSION_DENIED, resulting in zero documents indexed.This PR adds a
google_storage_bucket_iam_memberresource (corpus_bucket_discovery_engine) mirroring the existing KMS grant pattern incmek.tf, iterating over the samefor_eachmap used by the bucket resource.