fix(ime): forward real serial and time in on_keysym - #31
Open
kkimdev wants to merge 1 commit into
Open
Conversation
kkimdev
marked this pull request as ready for review
July 10, 2026 14:49
InternetOfTofu
self-requested a review
July 10, 2026 21:26
Collaborator
|
Hi kkimdev, I tried to see this PR in action but was unable to reproduce it. ( I tried "Chinese Pinyin" and "Japanese with US keyboard" IME, but did not see this event. Can you share how to reproduce it? or if it is not possible to repro it on a US chromebook keyboard? Thanks! (I'm happy to merge it if it's not possible to repro with my devices. If it is possible I want to run it before merging it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #30 for easier review.
wl_keyboard::key events forwarded from the IME's on_keysym handler used
serial=0 and time=0, which can cause the guest compositor to reject or
misorder them.
Fix
serial for later use by commit_state (PR 7).
Changes