fix(ime): implement set_preedit_region and fix done_serial tracking for Korean IME - #29
Closed
kkimdev wants to merge 3 commits into
Closed
fix(ime): implement set_preedit_region and fix done_serial tracking for Korean IME#29kkimdev wants to merge 3 commits into
kkimdev wants to merge 3 commits into
Conversation
kkimdev
force-pushed
the
wayland-ime-core-2-1
branch
from
July 8, 2026 23:18
58a3159 to
873c66b
Compare
kkimdev
force-pushed
the
wayland-ime-core-2-1
branch
from
July 8, 2026 23:26
873c66b to
81f201d
Compare
… forward real serial/time in on_keysym
Author
|
Replaced by full core-2 PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 2-1 of a stacked series (split from #27 for reviewability). PR 1 (#28) was a behavior-neutral refactor.
Last syllable lost when committing Korean text via Space/Enter
Composing "가나다" and pressing Space or Enter drops the final syllable "다".
Cause: Two bugs:
set_preedit_regionwas a no-op. ChromeOS IME calls this on every keystroke to describe where the composition starts relative to cursor. Without it the cursor offset is wrong when committing.doneserial was hardcoded to0. Guests validate serials — they discard updates where the serial has not advanced.Fix:
set_preedit_regioninto v3delete_surrounding_text+preedit_string+done.with_statehelper that manages a monotonically increasingdone_serial; wire to all done-sending paths.Known limitation: When the IME commit is followed by an Enter key event, the fix is incomplete. This requires the serial/activation changes from the next PR in the stack.