Skip to content

Feature/skill library updates - #13178

Open
eugene-manuilov wants to merge 5 commits into
developfrom
feature/skill-library-updates
Open

Feature/skill library updates#13178
eugene-manuilov wants to merge 5 commits into
developfrom
feature/skill-library-updates

Conversation

@eugene-manuilov

@eugene-manuilov eugene-manuilov commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses issue:

Relevant technical choices

Updated the review-pr playbook to check out the requested pr into a git worktree before verifying anything. This will let AI agent the whole picture and it will understand the codebase better.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Comment thread docs/context/workflow/review-pr.md Outdated
Comment on lines +25 to +26
Review the PR's **actual code**, not just the diff. Check the PR branch out into an isolated
git worktree so your current working tree and branch stay untouched:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The worktree sounds like a nice option but not always necessary. I can also see a reviewer being fine with checking out the PR as part of the review without a worktree (which also simplifies things below for running commands, etc).

How about we reword this into a question (if this is an interactive session) as to which the engineer would prefer?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the instructions to use the workspace approach only if the PR's branch hasn't already been checked out. Does it sound good to you?

@eugene-manuilov

Copy link
Copy Markdown
Collaborator Author

@aaemnnosttv, i have also updated our documentation for Datapoints as it was out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants