Feature/skill library updates - #13178
Open
eugene-manuilov wants to merge 5 commits into
Open
Conversation
aaemnnosttv
reviewed
Jul 24, 2026
Comment on lines
+25
to
+26
| Review the PR's **actual code**, not just the diff. Check the PR branch out into an isolated | ||
| git worktree so your current working tree and branch stay untouched: |
Collaborator
There was a problem hiding this comment.
The worktree sounds like a nice option but not always necessary. I can also see a reviewer being fine with checking out the PR as part of the review without a worktree (which also simplifies things below for running commands, etc).
How about we reword this into a question (if this is an interactive session) as to which the engineer would prefer?
Collaborator
Author
There was a problem hiding this comment.
I have updated the instructions to use the workspace approach only if the PR's branch hasn't already been checked out. Does it sound good to you?
…initions and usage examples.
Collaborator
Author
|
@aaemnnosttv, i have also updated our documentation for Datapoints as it was out of date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
Updated the review-pr playbook to check out the requested pr into a git worktree before verifying anything. This will let AI agent the whole picture and it will understand the codebase better.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist