Skip to content

fix(python): resolve mutable default arguments and side effects in http client #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afreireo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(python): resolve mutable default arguments and side effects in http client #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions sec-gemini-python/sec_gemini/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ def post(
return nr

def get(
self, endpoint: str, query_params: dict = {}, headers: dict = {}
self,
endpoint: str,
query_params: dict | None = None,
headers: dict | None = None,
) -> NetResponse:
"""Get Request to the API

Expand All @@ -97,6 +100,8 @@ def get(
Returns:
HTTPResponse: The response from the API.
"""
if query_params is None:
query_params = {}
url = self._make_url(endpoint)
headers = self._make_headers(headers)

Expand All @@ -123,11 +128,11 @@ def get(
def _make_url(self, endpoint: str) -> str:
return f"{self.base_url}/{endpoint.lstrip('/')}"

def _make_headers(self, headers: dict) -> dict:
def _make_headers(self, headers: dict | None) -> dict:
# User-Agent: Mozilla/5.0 (<system-information>) <platform> (<platform-details>) <extensions>

# request specific headers
headers = headers or {}
headers_copy = dict(headers) if headers else {}

additional_headers = {
"User-Agent": f"{SDKInfo.NAME.value}/{SDKInfo.VERSION.value} ({sys.platform}) {sys.version} ({sys.version_info})",
Expand All @@ -136,8 +141,8 @@ def _make_headers(self, headers: dict) -> dict:
"x-api-key": self.api_key,
"Content-Type": "application/json",
}
headers.update(additional_headers)
return headers
headers_copy.update(additional_headers)
return headers_copy

def _make_error_message(self, url: str, response: httpx.Response) -> str:
return f"[HTTP] {url} -> {response.status_code}:{response.text}"