tinyxml2: add xmldoctest and xmlprintertest fuzzers covering XMLDocument API and XMLPrinter#15770
Open
SomnathDas wants to merge 5 commits into
Open
tinyxml2: add xmldoctest and xmlprintertest fuzzers covering XMLDocument API and XMLPrinter#15770SomnathDas wants to merge 5 commits into
SomnathDas wants to merge 5 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
SomnathDas is a new contributor to projects/tinyxml2. The PR must be approved by known contributors before it can be merged. The past contributors are: arthurscchan, hunsche, vitaliset, kiddo-pwn, DonggeLiu, inferno-chromium, Dor1s, Androbin (unverified), jumde (unverified) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes ::
The existing
xmlfuzztarget only exercisesXMLDocument::Parse. Per the Introspector report dated 2026-06-16, the entire XMLPrinter class and a large portion of the XMLDocument API had 0% coverage.xmlprintertestcovers the full XMLPrinter surface: the streaming builder API (OpenElement, CloseElement, all PushAttribute and PushText typed overloads, PushComment, PushDeclaration, PushUnknown, PushHeader, ClearBuffer), the visitor dispatch path triggered via doc.Accept(), and the internal helpers PrintString, PrintSpace, and SealElementIfJustOpened which are reached transitively.xmldoctestcovers the XMLDocument construction and query API: all typed QueryValue and QueryText attribute/text conversion functions, all typed SetAttribute and SetText overloads, the full tree mutation API (New* factory methods, Insert*/DeleteChild/DeleteAttribute), document-level operations (DeepCopy, SaveFile, Clear), the ShallowClone/ShallowEqual/DeepClone paths, XMLHandle and XMLConstHandle traversal, and so on.Before ::
After ::
Locally ran for about

--seconds 180.