Sync a couple more changes#127
Merged
Merged
Conversation
Ensure device pose window won't call fatal errors and avoid GL rendering instead when trying to get color buffer contents for rendering foldable devices. Bug: 477193075 Test: manual, use device pose extended window controls with -feature GuestAngle Change-Id: Ic1436647ad4fe4bdaaa2ff0c61a985d7513eb723
Fixing these warnings either by adding a reference to the loop index's
type or removing the reference from it.
hardware/google/gfxstream/tests/end2end/TestDataUtils.cpp:65:29: error:
loop variable 'possiblePath' of type 'const std::string &'
(aka 'const basic_string<char> &') binds to a temporary constructed from
type 'reference' (aka 'const std::filesystem::path &')
[-Werror,-Wrange-loop-construct]
65 | for (const std::string& possiblePath : possiblePaths) {
| ^
hardware/google/gfxstream/tests/end2end/TestDataUtils.cpp:65:10: note: use
non-reference type 'std::string' (aka 'basic_string<char>') to make
construction explicit or type 'const std::filesystem::path &' to prevent
copying
65 | for (const std::string& possiblePath : possiblePaths) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Bug: 153747076
Test: m & presubmits
Flag: EXEMPT refactor
Change-Id: I457af4828122e9942f5f8508f7cbaf24bc596e22
Deleted in ag/39370045 as part of merge conflict resolution?
kocdemir
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.