Add JSON output support to Emboss text format#237
Open
AaronWebster wants to merge 1 commit into
Open
Conversation
reventlov
reviewed
Dec 3, 2025
| (void)emboss_reserved_local_wrote_field; | ||
| if (emboss_reserved_local_options.multiline()) { | ||
| if (emboss_reserved_local_wrote_field && | ||
| emboss_reserved_local_options.json()) { |
Contributor
There was a problem hiding this comment.
You can delete the && ...json() here and then lines 348-351 entirely, I believe.
Collaborator
Author
There was a problem hiding this comment.
That would break non-JSON multiline output, suggestion?
Add a `json` mode to TextOutputOptions so any view can be serialized as JSON, e.g. `WriteToString(view, TextOutputOptions().Json(true))`: - Field names are quoted and values are comma-separated; comments are suppressed. Compact output by default; multiline JSON places each field on its own indented line. - Enums serialize as quoted names (or bare numbers when the value has no name); bool as true/false; NaN and Infinity as quoted strings. - comments(), digit_grouping(), and numeric_base() automatically return JSON-appropriate values when json() is set, so callers don't have to special-case JSON throughout. - JsonLargeIntegerHandling::kLargeAsString optionally serializes integers wider than 32 bits as quoted strings, avoiding precision loss in JSON parsers that treat all numbers as IEEE-754 doubles. Adds JsonTestEnum/JsonTestArrayStruct/JsonTestStruct fixtures to testdata/text_format.emb and coverage in text_format_test.cc and emboss_array_view_test.cc. Regenerates the C++ goldens.
AaronWebster
force-pushed
the
text-output-json
branch
from
f29478b to
2db643d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JSON output support to Emboss text format