Do not bind to functions with unsatisfied trailing results clauses - #1858
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_967592498
branch
2 times, most recently
from
August 25, 2026 02:21
33989c5 to
ffb9ae9
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_967592498
branch
2 times, most recently
from
August 25, 2026 17:21
77ca4bc to
4442e3d
Compare
... or to functions that would transitively depend on same.
A previous version of this CL looked at isIneligibleOrNotSelected(),
but this bit is apparently changed at various points during typechecking,
and is not reliable for making this determination.
Documentation about this seems to be sparse (Clang says:
```
/// For member functions of complete types, whether this is an ineligible
/// special member function or an unselected destructor. See
/// [class.mem.special].
```
)
but `class.mem.special` doesn't seem to be a valid standard reference?
The relevant thing that's happening here is that we have a default member
function that won't be generated because its requires clause is not
satisfied:
```
_LIBCPP_HIDE_FROM_ABI atomic()
requires is_default_constructible_v<_Tp>
= default;
```
This change directly checks whether the trailing constraint is satisfied.
If not, we will not bind the function.
PiperOrigin-RevId: 970646733
copybara-service
Bot
force-pushed
the
test_967592498
branch
from
August 25, 2026 17:36
4442e3d to
1602287
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not bind to functions with unsatisfied trailing results clauses
... or to functions that would transitively depend on same.
A previous version of this CL looked at isIneligibleOrNotSelected(),
but this bit is apparently changed at various points during typechecking,
and is not reliable for making this determination.
Documentation about this seems to be sparse (Clang says:
)
but
class.mem.specialdoesn't seem to be a valid standard reference?The relevant thing that's happening here is that we have a default member
function that won't be generated because its requires clause is not
satisfied:
This change directly checks whether the trailing constraint is satisfied.
If not, we will not bind the function.