Clean up unused variable in operator[] bindings and enforce return type constness check - #1837
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_968025070
branch
3 times, most recently
from
August 25, 2026 17:23
814752a to
db2facf
Compare
…pe constness check In 129abed, `output_pointee_cc_type` was left unused in `generate_cc_operator_index_nonmut_impls` and `generate_cc_operator_index_mut_impls`. I was going to just delete it, but realized that the return-type constness check would be lost, so I moved it to the new code below it. PiperOrigin-RevId: 970648075
copybara-service
Bot
force-pushed
the
test_968025070
branch
from
August 25, 2026 17:41
db2facf to
a9875b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up unused variable in operator[] bindings and enforce return type constness check
In 129abed,
output_pointee_cc_typewas left unused ingenerate_cc_operator_index_nonmut_implsandgenerate_cc_operator_index_mut_impls. I was going to just delete it, but realized that the return-type constness check would be lost, so I moved it to the new code below it.