Use Abseil idioms for RAII cleanup, non-owning callbacks, and container algorithms - #1833
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_967903003
branch
5 times, most recently
from
August 25, 2026 17:39
b72afa7 to
5ac637b
Compare
…er algorithms I noticed that some areas with necessary cleanup after invoking a callback could be improved with `absl::Cleanup`, and that we were also using the allocating and deprecated `std::function` when we should be using `absl::FunctionRef`. I also cleaned up some lints suggesting to use `absl::c_sort` and `absl::c_transform` as opposed to the `std` variants. PiperOrigin-RevId: 970660531
copybara-service
Bot
force-pushed
the
test_967903003
branch
from
August 25, 2026 17:55
5ac637b to
8a5c16f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Abseil idioms for RAII cleanup, non-owning callbacks, and container algorithms
I noticed that some areas with necessary cleanup after invoking a callback could be improved with
absl::Cleanup, and that we were also using the allocating and deprecatedstd::functionwhen we should be usingabsl::FunctionRef. I also cleaned up some lints suggesting to useabsl::c_sortandabsl::c_transformas opposed to thestdvariants.