Skip bindings for fortified and variadic standard library functions. - #1824
Open
copybara-service[bot] wants to merge 1 commit into
Open
Skip bindings for fortified and variadic standard library functions.#1824copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_967290418
branch
from
August 19, 2026 21:07
64515ad to
875d122
Compare
Android Fortify introduces `sprintf` and `snprintf` overloads (with `enable_if`, `diagnose_if`, and variadics) that trigger `-Wformat-security` errors when wrapped in generated C++ thunks. This change: - Skips functions with `enable_if` or `diagnose_if` attributes. - Skips variadic functions requiring C++ thunks. PiperOrigin-RevId: 967290418
copybara-service
Bot
force-pushed
the
test_967290418
branch
from
August 19, 2026 21:21
875d122 to
d63caf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip bindings for fortified and variadic standard library functions.
Android Fortify introduces
sprintfandsnprintfoverloads (withenable_if,diagnose_if, and variadics) that trigger-Wformat-securityerrors when wrapped in generated C++ thunks.This change:
enable_ifordiagnose_ifattributes.