ci: grant contents: read explicitly on presubmit and deploy entry workflows#525
Merged
Merged
Conversation
The two deploy callers (postsubmit, unstable-channel) only pass secrets through to the reusable deployment.yaml. The reusable already declares contents: read at its workflow level, so the callers' explicit contents: read intersects to the same scope - no scope regression. presubmit.yaml builds Go, runs tests + lint, builds Debian and Docker artifacts, and runs E2E tests. All read-side from a GITHUB_TOKEN perspective.
arpitjain099
requested review from
Databean,
adelva1984,
jemoreira,
jmacnak,
rmuthiah and
ser-io
as code owners
Collaborator
|
Thanks for the contribution, and clear description in PR! Approved the PR. |
0405ysj
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three workflow files declare no
permissions:block.deployment.yaml(the reusable one called bypostsubmitandunstable-channel) already has an explicitpermissions: contents: read, but the three entry workflows still rely on the repo default.presubmit.yaml— build + test + format + vet + staticcheck + Debian/Docker artifact builds + E2E tests. All read-side from a GITHUB_TOKEN perspective.postsubmit.yamlandunstable-channel.yaml— both just delegate todeployment.yamlwith secrets. Addingcontents: readhere intersects with the reusables declaredcontents: read= same scope, no regression. TheARTIFACT_REGISTRY_UPLOADER` secret is what authenticates the actual GCP push.YAML parses cleanly.