Tidy README examples#58
Merged
Merged
Conversation
- Fix typo "MyFakeDatabse" -> "MyFakeDatabase". - Replace Joda-Time API in the WebDriver example with java.time (Duration.ofSeconds, plus pass MAX_WAIT directly to WebDriverWait which accepts java.time.Duration in modern Selenium). - Add the missing "new" keyword in install(...) module instantiations. - Lowercase code-block language tags for consistency. - Use "JUnit 4" with a space when referring to the framework version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MyFakeDatabse->MyFakeDatabasein the test isolation example.java.time:Duration.ofSeconds(5)and passMAX_WAITdirectly toWebDriverWait, which acceptsjava.time.Durationin modern Selenium.newkeyword ininstall(...)module instantiations across three examples.Java->java,XML->xml) for consistency.JUnit4.classliteral stays as-is — that's a class name).Test plan