Migrate ExpectedException to assertThrows#56
Merged
Conversation
ExpectedException has been deprecated since JUnit 4.13 in favor of assertThrows, which scopes the expectation to a specific call rather than the whole test method. Convert all uses across the test suite plus two equivalent try/catch+fail() blocks in AcaiTest. Where relevant, hoist non-throwing setup out of the assertThrows lambda to satisfy Error Prone's AssertThrowsMinimizer.
The only direct hamcrest reference was the isA matcher in TestingServiceManagerTest, which went away with the assertThrows migration. JUnit 4 still pulls in hamcrest-core transitively, so the explicit org.hamcrest:hamcrest:3.0 dep is no longer earning its keep.
nlativy
force-pushed
the
migrate-to-assertthrows
branch
from
4cfb643 to
c2703f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExpectedExceptionhas been deprecated since JUnit 4.13 in favor ofassertThrows, which scopes the expectation to a specific call rather than the whole test method.AcaiTest,DependenciesTest,TestScopeTest, andTestingServiceManagerTest. Also convert two equivalent try/catch+fail()blocks inAcaiTest.Acai.apply(...)returning aStatement) out of theassertThrowslambda to satisfy Error Prone'sAssertThrowsMinimizer.Test plan
mvn clean test— all 43 tests pass