Fix misleading error message in invokeIfBound#55
Merged
Conversation
The catch block hardcoded "Failed to invoke run on GuiceBerryEnvMain", but invokeIfBound is generic and is also called for TestWrapper and TestScopeListener methods. Format the message from the MethodReference instead so it names the actual class and method that failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invokeIfBoundis generic over aMethodReference, but itsReflectiveOperationExceptioncatch block hardcoded"Failed to invoke run on GuiceBerryEnvMain". It is also called forTestWrapper.toRunBeforeTest,TestScopeListener.enteringScope, andTestScopeListener.exitingScope, so the message was wrong in three of four call sites.MethodReferenceso it names the actual class and method that failed.Test plan
mvn clean test— all 43 tests pass