Fix checkpoint saving using wrong interval config#320
Conversation
The checkpoint saving condition checked `config.checkpoint_every` to determine whether checkpointing is enabled, but then incorrectly used `config.eval_every` for the modulo operation. This caused checkpoints to be saved at evaluation intervals instead of the configured checkpoint intervals, making the `checkpoint_every` config value effectively ignored. Replace `step % config.eval_every` with `step % config.checkpoint_every` so checkpoints are saved at the intended frequency.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
The only CI failure here is This is a human action: the CLA needs to be signed at https://cla.developers.google.com/ before Google can accept the PR. The check should re-run automatically once the CLA is on file for the Leaving the PR open — the maintainers will pick it up once the CLA clears. |
Summary
The checkpoint saving condition in
train.py(line 242) has a bug where it checksconfig.checkpoint_everyto determine whether checkpointing is enabled, but then incorrectly usesconfig.eval_everyfor the modulo operation:This causes checkpoints to be saved at evaluation intervals instead of the configured checkpoint intervals, making the
checkpoint_everyconfig value effectively ignored for controlling save frequency.Test plan
config.eval_everytoconfig.checkpoint_everyin the modulo check, matching the guard condition on the same line